Skip to content

Commit

Permalink
Add a comment about job signals
Browse files Browse the repository at this point in the history
  • Loading branch information
vxgmichel committed Jul 29, 2021
1 parent 09f0920 commit 17ecb51
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions parsec/core/gui/trio_thread.py
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,9 @@ def set_exception(self, exc):
def _set_done(self):
self._done.set()
signal = self._qt_on_success if self.is_ok() else self._qt_on_error
# TODO: Either pick a consistent API for those signals or get rid of the altogether.
# In the meantime, hack into the signal time in order to detect whether the job should
# be emitted as an argument to the signal
if signal.signal.endswith("(PyQt_PyObject)"):
signal.emit(self)
else:
Expand Down

0 comments on commit 17ecb51

Please sign in to comment.