Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SS-1211 add e2e test to check that user cannot create a new project with the same name #261

Conversation

anondo1969
Copy link
Contributor

@anondo1969 anondo1969 commented Nov 27, 2024

Description

Source: https://scilifelab.atlassian.net/browse/SS-1211

  1. Superuser can create project with existing project-name.
  2. Other users can not create such project.

Checklist

If you're unsure about any of the items below, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • This pull request is against develop branch (not applicable for hotfixes)
  • I have included a link to the issue on GitHub or JIRA (if any)
  • I have included migration files (if there are changes to the model classes)
  • I have included, reviewed and executed tests (unit and end2end) to complement my changes
  • I have updated the related documentation (if necessary)
  • I have added a reviewer for this pull request
  • I have added myself as an author for this pull request
  • In the case I have modified settings.py, then I have also updated the studio-settings-configmap.yaml file in serve-charts

Further comments

Anything else you think we should know before merging your code!

@anondo1969 anondo1969 self-assigned this Nov 28, 2024
@anondo1969 anondo1969 marked this pull request as ready for review November 28, 2024 08:20
@anondo1969 anondo1969 requested a review from akochari November 28, 2024 08:20
Copy link
Collaborator

@akochari akochari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! I just simplified the tests a bit.

@anondo1969 anondo1969 merged commit 3f61cb4 into develop Nov 28, 2024
2 checks passed
@anondo1969 anondo1969 deleted the SS-1211-Add-e2e-test-to-check-that-user-cannot-create-a-new-project-with-the-same-name branch November 28, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants