Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SS-1141 Bump charts versions for apps with support of custom error pages on a nginx level #260

Merged
merged 3 commits into from
Nov 29, 2024
Merged

SS-1141 Bump charts versions for apps with support of custom error pages on a nginx level #260

merged 3 commits into from
Nov 29, 2024

Conversation

churnikov
Copy link
Contributor

No description provided.

@churnikov
Bump charts versions
89c9444 
Signed-off-by: Nikita Churikov <[email protected]>
@churnikov churnikov added the change Change of code functionality label Nov 27, 2024
@churnikov churnikov requested review from hamzaimran08 and a team November 27, 2024 14:40
@churnikov churnikov self-assigned this Nov 27, 2024
@churnikov churnikov mentioned this pull request Nov 27, 2024
Merged
hamzaimran08
hamzaimran08 requested changes Nov 28, 2024
View reviewed changes
Copy link
Collaborator

@hamzaimran08 hamzaimran08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think netpolicy and volume were not bumped in the charts (because they are not deployments). Also, I think the custom-app chart for streamlit needs to be bumped as well

fixtures/apps_fixtures.json Outdated Show resolved Hide resolved
fixtures/apps_fixtures.json Outdated Show resolved Hide resolved
hamzaimran08
hamzaimran08 approved these changes Nov 28, 2024
View reviewed changes
Copy link
Collaborator

@hamzaimran08 hamzaimran08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@churnikov churnikov merged commit b4b67df into develop Nov 29, 2024
2 checks passed
@churnikov churnikov deleted the SS-1141-bump-versions-for-custom-err-pages branch November 29, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamzaimran08 hamzaimran08 hamzaimran08 approved these changes

Assignees

@churnikov churnikov

Labels
change Change of code functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@churnikov @hamzaimran08