SS-1206 Site dir option should have path validation #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
churnikov
approved these changes
Nov 28, 2024
Comment on lines
+5
to
+6
| import regex as re | ||
| from django.core.exceptions import ObjectDoesNotExist, ValidationError |
There was a problem hiding this comment.
Isort was not applied here
There was a problem hiding this comment.
made type hint correct Co-authored-by: Nikita Churikov <[email protected]>
churnikov
approved these changes
Nov 29, 2024
anondo1969
deleted the
SS-1206-Site-dir-option-should-have-path-validation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Source: https://scilifelab.atlassian.net/browse/SS-1206
The site-dir option in shinyproxy apps should disallow paths/like\ this . This would fail in the helm deployment.
We’d like side-dir to be compatible with k8s labels specification Labels and Selectors
Valid label value:
must be 63 characters or less (can be empty),
unless empty, must begin and end with an alphanumeric character ([a-z0-9A-Z]),
could contain dashes (-), underscores (_), dots (.), and alphanumerics between.
Checklist
If you're unsure about any of the items below, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
Further comments
Anything else you think we should know before merging your code!