Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SS-1206 site dir option should have path validation #258

Closed

Conversation

anondo1969
Copy link
Contributor

@anondo1969 anondo1969 commented Nov 26, 2024

Status

Draft

Description

Source: https://scilifelab.atlassian.net/browse/SS-1206

The site-dir option in shinyproxy apps should disallow paths/like\ this . This would fail in the helm deployment.

We’d like side-dir to be compatible with k8s labels specification Labels and Selectors

Valid label value:

must be 63 characters or less (can be empty),

unless empty, must begin and end with an alphanumeric character ([a-z0-9A-Z]),

could contain dashes (-), underscores (_), dots (.), and alphanumerics between.

Types of changes

To indicate the type of change (such as bugfix or new feature), use a github pull request label.

Checklist

If you're unsure about any of the items below, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • This pull request is against develop branch (not applicable for hotfixes)
  • I have included a link to the issue on GitHub or JIRA (if any)
  • I have included migration files (if there are changes to the model classes)
  • I have included, reviewed and executed tests (unit and end2end) to complement my changes
  • I have updated the related documentation (if necessary)
  • I have added a reviewer for this pull request
  • I have added myself as an author for this pull request
  • In the case I have modified settings.py, then I have also updated the studio-settings-configmap.yaml file in serve-charts

Further comments

Anything else you think we should know before merging your code!

@anondo1969 anondo1969 self-assigned this Nov 26, 2024
@anondo1969 anondo1969 closed this Nov 27, 2024
@anondo1969 anondo1969 deleted the SS-1206-Site-dir-option-should-have-path-validation branch November 27, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant