-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SS-556 allow flavors with gpu in jupyter labs #246
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why make this restriction, when flavors can be created only by us?
Because the same Flavor can be used by different apps as well and then they will have GPUs allocated and we don't want that. Right now we only want to test with Jupyter Labs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few unit tests verifying creating a new gpu based flavor for JL notebooks and not being able to create for other app types would be helpful.
Description
This change relates to issue SS-556. Jupyter Labs are allowed to be allocated GPUs if the environment is configured to have GPUs.
Types of changes
To indicate the type of change (such as bugfix or new feature), use a github pull request label.
Checklist
If you're unsure about any of the items below, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
Further comments
Anything else you think we should know before merging your code!