SS-1191: Bugfix related to environment and flavor deletion

[akochari]

Description

This PR contains bugfix SS-1191 - environment and flavor deletion from the UI resulted in internal server error when these were currently used in an app. While working on it, I also made a number of other improvements:

• regular users no longer allowed to send post requests to endpoints to create and delete flavors and environments
• flavor and environment deletion is not allowed from the django admin panel either
• added unit tests for flavor and environment creation and deletion

This PR also includes an unrelated small change that was missed in previous PR: allowing display of instructions to run Gradio and Streamlit apps locally with Docker.

Finally, this PR includes an updated Serve logo

Checklist

If you're unsure about any of the items below, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

• This pull request is against develop branch (not applicable for hotfixes)
• I have included a link to the issue on GitHub or JIRA (if any)
• I have included migration files (if there are changes to the model classes)
• I have included, reviewed and executed tests (unit and end2end) to complement my changes
• I have updated the related documentation (if necessary)
• I have added a reviewer for this pull request
• I have added myself as an author for this pull request
• In the case I have modified settings.py, then I have also updated the studio-settings-configmap.yaml file in serve-charts

[churnikov]

Do I get it right, that this pr has to do with these errors?

[akochari]

Do I get it right, that this pr has to do with these errors?

No, these errors are coming from periodic tasks. That's solved in PR #239

Copilot reviewed 5 out of 10 changed files in this pull request and generated no suggestions.

Files not reviewed (5)

• templates/common/app_card.html: Language not supported
• templates/projects/settings.html: Language not supported
• apps/migrations/0019_alter_jupyterinstance_environment_and_more.py: Evaluated as low risk
• apps/models/app_types/jupyter.py: Evaluated as low risk
• apps/models/app_types/rstudio.py: Evaluated as low risk

Comments skipped due to low confidence (3)

projects/tests/test_create_delete_environments.py:23

• [nitpick] The method name test_environment_creation_user should be test_environment_creation_by_user for better readability.

def test_environment_creation_user(self):

projects/tests/test_create_delete_environments.py:60

• [nitpick] The method name test_environment_creation_deletion_superuser should be test_environment_creation_and_deletion_by_superuser for better readability.

def test_environment_creation_deletion_superuser(self):

projects/tests/test_create_delete_environments.py:24

• The docstring should be updated to "Test regular user is not allowed to create environment".

"""Test regular user not allowed to create environment"""

[alfredeen]

LGTM

[churnikov]

These are just minor comment, after them LGTM

[churnikov]

What to do if it's a deleted app?

[akochari]

I think then we are not allowed to delete that flavor. If there is a use case where it is needed we can implement something else later I think. It may have repercussions further down, not sure.

[churnikov]

Just a small suggestion that could be applied to most of the other test. Otherwise, lgtm