Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SS-1108 environment support in jupyter notebooks #223

Merged
merged 7 commits into from
Sep 11, 2024

Conversation

churnikov
Copy link
Contributor

Status

To set the status of the pull request, use the built-in github feature to set the PR as Draft or Ready for review.

Description

In serve we already had support for environments. We are just bringing it back to jupyter notebooks

Checklist

If you're unsure about any of the items below, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • This pull request is against develop branch (not applicable for hotfixes)
  • I have included a link to the issue on GitHub or JIRA (if any)
  • I have included migration files (if there are changes to the model classes)
  • I have included, reviewed and executed tests (unit and end2end) to complement my changes
  • I have updated the related documentation (if necessary)
  • I have added a reviewer for this pull request
  • I have added myself as an author for this pull request
  • In the case I have modified settings.py, then I have also updated the studio-settings-configmap.yaml file in serve-charts

@churnikov churnikov requested review from akochari and a team September 6, 2024 18:33
@churnikov churnikov self-assigned this Sep 6, 2024
@churnikov churnikov added the change Change of code functionality label Sep 6, 2024
Added info to the environment creation view that it's a legacy way to create an environment via serve ui;
Updated help text for environment's fields. They are being displayed like written in the admin form for environment creation;
@churnikov churnikov marked this pull request as ready for review September 9, 2024 15:31
@akochari
Copy link
Collaborator

Looks great! Nice that we could revive this easily!
I will just add an e2e test of creating a new environment within the next couple of days.

@akochari
Copy link
Collaborator

Now e2e added and passing.

Copy link
Collaborator

@akochari akochari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@churnikov churnikov merged commit c35dc1c into develop Sep 11, 2024
2 checks passed
@churnikov churnikov deleted the SS-1108-environments-support-for-jupyter branch September 11, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change Change of code functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants