Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SS-1043 Update app creation template header #208

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

churnikov
Copy link
Contributor

@churnikov churnikov commented Jul 25, 2024

Description

Update app creation template so that title would change based on users intent to update app settings or to create an app

Checklist

If you're unsure about any of the items below, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • This pull request is against develop branch (not applicable for hotfixes)
  • I have included a link to the issue on GitHub or JIRA (if any)
  • I have included migration files (if there are changes to the model classes)
  • I have included, reviewed and executed tests (unit and end2end) to complement my changes
  • I have updated the related documentation (if necessary)
  • I have added a reviewer for this pull request
  • I have added myself as an author for this pull request
  • In the case I have modified settings.py, then I have also updated the studio-settings-configmap.yaml file in serve-charts

…s intent to update app settings or to create an app
@churnikov churnikov added the enhancement Improvement of existing feature or request label Jul 25, 2024
@churnikov churnikov requested a review from hamzaimran08 July 25, 2024 13:49
@churnikov churnikov self-assigned this Jul 25, 2024
@churnikov churnikov merged commit 8e0645d into develop Aug 1, 2024
2 checks passed
@churnikov churnikov deleted the SS-1043-fix-apps-settings-view-header branch August 1, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of existing feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants