Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SS-887-custom-404-page #187

Merged
merged 2 commits into from
Apr 9, 2024
Merged

SS-887-custom-404-page #187

merged 2 commits into from
Apr 9, 2024

Conversation

churnikov
Copy link
Contributor

@churnikov churnikov commented Apr 8, 2024

Description

This draft PR add a template for django pages that are not found. For the pages, that won't be found on the k8s side, we need to a page on rancher side. @hamzaimran08 said, that he would provide more info on this the SS-887 task.

Checklist

If you're unsure about any of the items below, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • [ x ] This pull request is against develop branch (not applicable for hotfixes)
  • [ x ] I have included a link to the issue on GitHub or JIRA (if any)
  • I have included migration files (if there are changes to the model classes)
  • I have included, reviewed and executed tests (unit and end2end) to complement my changes
  • I have updated the related documentation (if necessary)
  • [ x ] I have added a reviewer for this pull request
  • [ x ] I have added myself as an author for this pull request
  • In the case I have modified settings.py, then I have also updated the studio-settings-configmap.yaml file in serve-charts

Further comments

Anything else you think we should know before merging your code!

@churnikov churnikov requested a review from a team April 8, 2024 15:24
@churnikov churnikov self-assigned this Apr 8, 2024
@churnikov churnikov added the enhancement Improvement of existing feature or request label Apr 8, 2024
@churnikov churnikov marked this pull request as ready for review April 8, 2024 15:25
Copy link
Contributor

@sandstromviktor sandstromviktor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT lets merge

@akochari akochari merged commit 78f16da into develop Apr 9, 2024
2 checks passed
@akochari akochari deleted the SS-887-custom-404-page branch April 9, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of existing feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants