SS 829 issue with non unique docker images #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandstromviktor
commented
Jan 18, 2024
| @@ -71,7 +71,7 @@ <h4>Important information</h4> | |||
| <label class="form-label">Description</label> | |||
| <span class="bi bi-question-circle" style="color: #989da0" data-bs-toggle="tooltip" title="" data-bs-placement="right" data-bs-original-title="Summarize the application in a few words"> | |||
| </span> | |||
| <textarea type="text" id="app_description" name="app_description" value="{{ existing_app_description }}" | |||
| <textarea type="text" id="app_description" name="app_description" value="" | |||
There was a problem hiding this comment.
Removed it since it does not exist in the view ever.
churnikov
approved these changes
Jan 18, 2024
churnikov
reviewed
Jan 18, 2024
sandstromviktor
deleted the
SS-829-issue-with-non-unique-docker-images
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Solves bug
SS-829. I've changed the
imagePullPolicytoAlwayson all relevant charts. In ShinyProxy, i've setproxy.kubernetes.image-pull-policytoAlways. This means that the Proxy image pull policy remains atIfNotPresent, but the container used in the temporary pod has the correct policy.Checklist
If you're unsure about any of the items below, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.