Added a ci-wheels yml #135
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,120 @@ | ||
| # Reference: | ||
| # - https://github.com/actions/checkout | ||
| # - https://github.com/actions/download-artifact | ||
| # - https://github.com/actions/upload-artifact | ||
| # - https://github.com/pypa/cibuildwheel | ||
| # - https://github.com/pypa/build | ||
| # - https://github.com/pypa/gh-action-pypi-publish | ||
| # - https://test.pypi.org/help/#apitoken | ||
|
|
||
| name: ci-wheels | ||
|
|
||
| on: | ||
| pull_request: | ||
|
|
||
| push: | ||
| branches: | ||
| - "main" | ||
| - "v*x" | ||
| - "!auto-update-lockfiles" | ||
| - "!pre-commit-ci-update-config" | ||
| - "!dependabot/*" | ||
| tags: | ||
| - "v*" | ||
|
|
||
| jobs: | ||
| build_bdist: | ||
|
There was a problem hiding this comment. This job is not currently creating a built distribution ("bdist") - it only has 1 step - checking out the repo. |
||
| name: "build ${{ matrix.os }} (${{ matrix.arch }}) wheels" | ||
| runs-on: ${{ matrix.os }} | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
|
There was a problem hiding this comment. It looks like Tephi is agnostic to OS - there are no OS-specific files here: https://pypi.org/project/tephi/#files 1 So the matrix should be unnecessary. E.g. Footnotes |
||
| os: ["ubuntu-latest", "macos-latest", "windows-latest"] | ||
| arch: ["x86_64", "arm64"] | ||
| exclude: | ||
| - os: "ubuntu-latest" | ||
| arch: "arm64" | ||
| - os: "windows-latest" | ||
| arch: "x86_64" | ||
| - os: "windows-latest" | ||
| arch: "arm64" | ||
| include: | ||
| - os: "windows-latest" | ||
| arch: "AMD64" | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 0 | ||
|
|
||
| build_sdist: | ||
| name: "Build sdist" | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 0 | ||
|
|
||
| - name: "Building sdist" | ||
| shell: bash | ||
| run: | | ||
| pipx run build --sdist | ||
|
|
||
| - uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: pypi-sdist | ||
| path: ${{ github.workspace }}/dist/*.tar.gz | ||
|
|
||
|
|
||
| show-artifacts: | ||
|
There was a problem hiding this comment. Several other repos include a test stage. Looks like they download the artifacts and make sure that each provides a functional instance of the package. Repos with this:
Repos without this:
It looks like the only times that we skip this are for repos that include Cython (and therefore build using cibuildwheel). Tephi is not in this camp, so could it include a testing stage? |
||
| needs: [build_bdist, build_sdist] | ||
| name: "Show artifacts" | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/download-artifact@v4 | ||
| with: | ||
| merge-multiple: true | ||
| path: ${{ github.workspace }}/dist | ||
|
|
||
| - shell: bash | ||
| run: | | ||
| ls -l ${{ github.workspace }}/dist | ||
|
|
||
|
|
||
| publish-artifacts-test-pypi: | ||
| needs: [build_bdist, build_sdist] | ||
| name: "Publish to Test PyPI" | ||
| runs-on: ubuntu-latest | ||
| # upload to Test PyPI for every commit on main branch | ||
| if: github.event_name == 'push' && github.event.ref == 'refs/heads/main' | ||
|
There was a problem hiding this comment. In other repos you have suggested a check for the repository owner, too: SciTools/iris#5180. Can that be included here too? |
||
| steps: | ||
| - uses: actions/download-artifact@v4 | ||
| with: | ||
| merge-multiple: true | ||
| path: ${{ github.workspace }}/dist | ||
|
|
||
| - uses: pypa/gh-action-pypi-publish@release/v1 | ||
| with: | ||
| user: __token__ | ||
| password: ${{ secrets.TEST_PYPI }} | ||
| repository_url: https://test.pypi.org/legacy/ | ||
| skip_existing: true | ||
| print_hash: true | ||
|
|
||
| publish-artifacts-pypi: | ||
| needs: [build_bdist, build_sdist] | ||
| name: "Publish to PyPI" | ||
| runs-on: ubuntu-latest | ||
| # upload to PyPI for every tag starting with 'v' | ||
| if: github.event_name == 'push' && startsWith(github.event.ref, 'refs/tags/v') | ||
| steps: | ||
| - uses: actions/download-artifact@v4 | ||
| with: | ||
| merge-multiple: true | ||
| path: ${{ github.workspace }}/dist | ||
|
|
||
| - uses: pypa/gh-action-pypi-publish@release/v1 | ||
| with: | ||
| user: __token__ | ||
| password: ${{ secrets.PYPI }} | ||
| print_hash: true | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're not using cibuildwheel