Improve handling of masks in concatenate #6187
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
The following arrays compare equal in
iris.util.array_equal
, so they should also compare equal in the hash function used by concatenate:np.array([1, 2])
andnp.ma.array([1, 2], mask=np.ma.nomask)
np.array([1, 2])
andnp.ma.array([1, 2], mask=[0, 0])
np.ma.array([1, 2], mask=[0, 0])
andnp.ma.array([1, 2], mask=np.ma.nomask)
Consult Iris pull request check list
Add any of the below labels to trigger actions on this PR: