-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add location argument to mesh.coords #6055
add location argument to mesh.coords #6055
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6055 +/- ##
=======================================
Coverage 89.76% 89.76%
=======================================
Files 90 90
Lines 22996 22991 -5
Branches 5032 5030 -2
=======================================
- Hits 20642 20638 -4
Misses 1623 1623
+ Partials 731 730 -1 ☔ View full report in Codecov by Sentry. |
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some fairly wide scope things for you. I will hold off more detailed reviewing until we have some conclusions.
Thanks!
* main: Quieter datum warning (SciTools#6050) Allow MeshCoord to have a coord-system (SciTools#6016) Bump scitools/workflows from 2024.07.1 to 2024.07.2 (SciTools#6053)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful work @stephenworsley - neater, less confusing, and true to the original philosophy of identical signatures all eventually passing down to the filters()
method.
* main: Rename `Mesh` to `MeshXY` (SciTools#6056) Bump scitools/workflows from 2024.07.2 to 2024.07.3 (SciTools#6063) # Conflicts: # docs/src/whatsnew/latest.rst
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good I think, just needs an approval.
* upstream/main: Updated environment lockfiles (SciTools#6029) Pin matplotlib != 3.9.1 (SciTools#6065) add location argument to mesh.coords (SciTools#6055) Doctest compatibility with GeoVista v0.5. (SciTools#6064) Rename `Mesh` to `MeshXY` (SciTools#6056) Bump scitools/workflows from 2024.07.2 to 2024.07.3 (SciTools#6063)
🚀 Pull Request
Closes #5993