Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark logo #5278

Merged
merged 5 commits into from
Apr 26, 2023
Merged

Dark logo #5278

merged 5 commits into from
Apr 26, 2023

Conversation

trexfeathers
Copy link
Contributor

🚀 Pull Request

Description

Ref: #4795


Consult Iris pull request check list

@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (0651af7) 89.32% compared to head (e12c4c8) 89.32%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5278   +/-   ##
=======================================
  Coverage   89.32%   89.32%           
=======================================
  Files          89       89           
  Lines       22390    22390           
  Branches     5374     5374           
=======================================
  Hits        20000    20000           
  Misses       1640     1640           
  Partials      750      750           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@trexfeathers
Copy link
Contributor Author

I can build the documentation locally, so I'm not sure what's going on with RTD taking forever at the build step.

@tkknight
Copy link
Contributor

I can build the documentation locally, so I'm not sure what's going on with RTD taking forever at the build step.

I think RTD is having issues. I cannot even "cancel build" and restart it - it will time out eventually. Happy to merge once the docs on RTD build ok.

@trexfeathers
Copy link
Contributor Author

The RTD build demonstrates:

@tkknight tkknight merged commit bbb5358 into SciTools:main Apr 26, 2023
@trexfeathers trexfeathers deleted the dark_logo branch May 3, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants