iris.util.new_axis anonymous new dimension fix #5194
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #5194 +/- ##
=======================================
Coverage 89.26% 89.27%
=======================================
Files 88 88
Lines 22233 22238 +5
Branches 4863 4863
=======================================
+ Hits 19847 19852 +5
Misses 1641 1641
Partials 745 745
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
@scottrobinson02 This is a lovely contribution, thanks so much 💯
If you could discriminate between the two different cases that generate the same exception, then that would be awesome 🤩
You'll probably have to bolster the units tests to cover this scenario.
Also, please make sure to add an entry in the documentation whatsnew - you totally deserve the recognition and credit for your contribution.
See the latest.rst and the 🐛 Bugs Fixed section 👍
If you need any help or advice, don't hesitate to ask 😄
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
@scottrobinson02 Awesome. Thanks for your first contribution to iris 🥳 🎉 💯
* upstream/main: (274 commits) Cf cell method (SciTools#5224) Bump scitools/workflows from 2023.03.3 to 2023.04.1 (SciTools#5231) [pre-commit.ci] pre-commit autoupdate (SciTools#5230) Bump scitools/workflows from 2023.03.2 to 2023.03.3 (SciTools#5227) raise dask min pin (SciTools#5225) Enable lazy computation of wind vector rotation (SciTools#4972) Benchmark runner script (SciTools#5215) add locks readme (SciTools#5222) use explicit version for ci refresh-lockfiles gha (SciTools#5221) SciTools#5180 do not run publish-to-test-pypi on forks (SciTools#5220) Fix Makefile for consequences of SciTools#5204. (SciTools#5217) Bump actions/stale from 7 to 8 (SciTools#5208) Remove Iris' TestRunner (SciTools#5205) standardize requirements structure (SciTools#5204) Updated environment lockfiles (SciTools#5199) Add histogram convenience for passing Iris objects to plt.hist (SciTools#5189) Updated environment lockfiles (SciTools#5192) announce new contributor in whatsnew (SciTools#5198) iris.util.new_axis anonymous new dimension fix (SciTools#5194) Lockfiles and pydata-sphinx-theme fix (SciTools#5188) ...
🚀 Pull Request
Closes #4415
Description
Passing an existing dim coord to iris.util.new_axis now raises an exception