Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken cartopy links in docs #4464

Merged
merged 4 commits into from
Jan 5, 2022

Conversation

wjbenfold
Copy link
Contributor

🚀 Pull Request

Description

Addressing AVD-1897, I've fixed some broken links to cartopy (where .GeoAxes has become .geoaxes.GeoAxes). Also worked around a couple of ones broken as a result of SciTools/cartopy#1972


Consult Iris pull request check list

Copy link
Contributor

@trexfeathers trexfeathers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wjbenfold, I can confirm that the altered links work as expected.

Definitely worth a What's New entry though, to show the work that goes into keeping this project going 😊

@trexfeathers trexfeathers merged commit f47fb97 into SciTools:main Jan 5, 2022
@wjbenfold wjbenfold deleted the wjbenfold-docs-cartopy-links branch January 5, 2022 16:52
tkknight added a commit to tkknight/iris that referenced this pull request Jan 6, 2022
* main:
  Use partial to make cube pickleable (SciTools#4377)
  Add edit via github method to Iris docs (SciTools#4461)
  Broken cartopy links in docs (SciTools#4464)
  rtd with latest mambaforge image for faster building (SciTools#4476)
  Show acceptable image test results in the docs (SciTools#4392)
  Nc load latlon fix (SciTools#4470)
  update matplotlib links (SciTools#4474)
  Whatsnew for PR 4462 (SciTools#4475)
  Clarify the return type of iris.load (AVD-1899) (SciTools#4462)
  [pre-commit.ci] pre-commit autoupdate (SciTools#4472)
  Updated environment lockfiles (SciTools#4467)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants