-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix whatsnew api links. #3856
Fix whatsnew api links. #3856
Conversation
@pp-mo I think there might be some more too. I'm just going to build some docs from this PR, go through and make a full list... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While here, please could you also address:
~iris.Cube.cube.remove_coord
on L50- L64, where trailing an
s
after~iris.coords.CellMeasure
appears to have prevented several words rendering
👍 for diligence. I followed your suggestions.
|
Some ideas also occurred to me, to improve the Ancillary Data features entry... But maybe I should just create another PR for that? ? What do you think @trexfeathers @bjlittle |
@pp-mo I'm afraid, having not worked on this area of the code at all, I don't have an educated view on the correct amount of detail. This entry was the one merged from the feature branch, so I had assumed that all 3 of you working on it had seen it at the time.
@pp-mo that would be good Git practice I think
@pp-mo I was imagining that something of this sort should be written once we're sure nothing else is getting merged. I'm not sure how we decide what goes into it, since none of us have touched all the new features. |
0b6cc57
to
24d3634
Compare
Sorry, a bunch of commits targetting the whatsnew were just merged, causing conflicts here, and it seemed simpler to rebase, so I did. |
Review changes, plus extras.
24d3634
to
4e23150
Compare
* master: Whatsnew for effects on aux factories of units defaulting to 'unknown'. (SciTools#3870) Whatsnew entry for SciTools#3867. (SciTools#3868) Developer guide overhaul (SciTools#3852) Update CF standard name table to v75 (SciTools#3867) Link to new classes and methods in the Ancillary variables whatsnew. (SciTools#3865) update black version (SciTools#3866) Fix whatsnew api links. (SciTools#3856) Add additional pre-commit hooks (SciTools#3862) update pre-commit flake8 version (SciTools#3863) whatsnew - update announcement (SciTools#3861) whatsnew - remove contents directive (SciTools#3859) whatsnew - links and versions (SciTools#3853) Replace deprecated IndexFormatter (SciTools#3857) whatsnew for SciTools#3681 (SciTools#3858) Whatsnew entry for SciTools#3846. (SciTools#3855) Image tests: set agg backend after rcdefaults (SciTools#3846) whatnew - announcements (SciTools#3850)
🚀 Pull Request
Description
A really tiny improvement : I was checking out the new whatsnew format + I noticed that these API refs were subtly wrong + don't function as links.