Skip to content

Commit

Permalink
build wheel from sdist, not src (#5266)
Browse files Browse the repository at this point in the history
* build wheel from sdist, not src

* add whatsnew entry
  • Loading branch information
bjlittle authored Apr 21, 2023
1 parent 94e44ef commit ac0c2b7
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
4 changes: 1 addition & 3 deletions .github/workflows/ci-wheels.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,7 @@ jobs:
- name: "building"
shell: bash
run: |
# require build with explicit --sdist and --wheel in order to
# get correct version associated with sdist and bdist artifacts
pipx run build --sdist --wheel
pipx run build
- uses: actions/upload-artifact@v3
with:
Expand Down
4 changes: 4 additions & 0 deletions docs/src/whatsnew/latest.rst
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,9 @@ This document explains the changes made to Iris for this release
#. `@bjlittle`_ and `@trexfeathers`_ (reviewer) migrated ``setup.cfg`` to
``pyproject.toml``, as motivated by `PEP-0621`_. (:pull:`5262`)

#. `@bjlittle`_ adopted `pypa/build`_ recommended best practice to build a
binary ``wheel`` from the ``sdist``. (:pull:`5266`)


.. comment
Whatsnew author names (@github name) in alphabetical order. Note that,
Expand All @@ -134,3 +137,4 @@ This document explains the changes made to Iris for this release
.. _sphinx-design: https://github.com/executablebooks/sphinx-design
.. _check-manifest: https://github.com/mgedmin/check-manifest
.. _PEP-0621: https://peps.python.org/pep-0621/
.. _pypa/build: https://pypa-build.readthedocs.io/en/stable/

0 comments on commit ac0c2b7

Please sign in to comment.