Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the empty file that isn't required for PEP420, but is required for setuptools.find_packages() #146

Merged
merged 1 commit into from
Feb 2, 2019

Conversation

pelson
Copy link
Member

@pelson pelson commented Feb 2, 2019

Turns out you do actually need empty __init__.py files, even with Python 3, if you are using setuptools.find_packages. This cropped up when I did the final testing of the v2.1.0 release. We will therefore be going straight to v2.1.1 🤣 .

pypa/setuptools#97 relates

@stickler-ci
Copy link

Could not review pull request. It may be too large, or contain no reviewable changes.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 88.638% when pulling 515eb96 on pelson:pep420_fix into 90c705f on SciTools:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 88.638% when pulling 515eb96 on pelson:pep420_fix into 90c705f on SciTools:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 88.638% when pulling 515eb96 on pelson:pep420_fix into 90c705f on SciTools:master.

@pelson pelson merged commit 812009c into SciTools:master Feb 2, 2019
@pelson pelson deleted the pep420_fix branch February 2, 2019 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants