Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: contour sticky edges match dataLim #2414

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

rcomer
Copy link
Member

@rcomer rcomer commented Jul 11, 2024

Rationale

Fixes #2413. The problem seems to be that we have a very small mismatch between the artist's sticky edges and the axes dataLim. Within Matplotlib's contour code, these are set equal.

I have tested locally with both mpl nightly and mpl 3.8.4. Note that matplotlib/matplotlib#28393 was included in mpl 3.9.1 so our CI should already use the new version.

Implications

Copy link
Contributor

@greglucas greglucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job tracking this down! Thanks for the quick fix.

@greglucas
Copy link
Contributor

@rcomer have you not signed the new CLA yet? I can't find a way to refresh that check now either...

@rcomer
Copy link
Member Author

rcomer commented Jul 11, 2024

@rcomer have you not signed the new CLA yet? I can't find a way to refresh that check now either...

I got a pass from signing it as I'm publicly a member of the Met Office GitHub organisation. But the checker seems broken. @trexfeathers any ideas?

@trexfeathers
Copy link
Contributor

You can recheck using this URL:

https://cla-assistant.io/check/SciTools/cartopy?pullRequest=2414

I have sometimes needed to try a couple of times when the service is patchy.

I'm keen to find a good place to share this information. Any thoughts would be welcomed. This could include a note in each repository if we can't think of a good central place

@greglucas
Copy link
Contributor

@trexfeathers Is there a way to add that in the "Details" section? It was just stalled previously, so if there were a way to re-run it from this page directly that would be ideal. But a link somewhere else might be useful, although I'm guaranteed to forget about where that link is I'm sure ;)
image

@greglucas greglucas merged commit 11bb8d3 into SciTools:main Jul 11, 2024
23 of 25 checks passed
@rcomer
Copy link
Member Author

rcomer commented Jul 11, 2024

I'm guaranteed to forget about where that link is I'm sure ;)

I think @trexfeathers already had told me about it...

@rcomer rcomer deleted the sticky-contour branch July 11, 2024 20:11
@trexfeathers
Copy link
Contributor

@trexfeathers Is there a way to add that in the "Details" section? It was just stalled previously, so if there were a way to re-run it from this page directly that would be ideal. But a link somewhere else might be useful, although I'm guaranteed to forget about where that link is I'm sure ;) image

Probably not, since at this point it hasn't run. All GitHub knows it should expect something with that name.

I got the URL from the comments that are posted when people still need to sign, so CLAAssistant are providing the information whenever they can. It's my fault for making it a required check.

This is the only place I can think of but that's very hidden at the point that a note would be needed:

* Note that you will automatically be asked to sign the
[Contributor Licence Agreement](https://cla-assistant.io/SciTools/)
(CLA), if you have not already done so.
-->

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TST] Upcoming dependency test failures
3 participants