Update contour extents #1712
Merged
Update contour extents #1712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greglucas
force-pushed
the
contour_bounds
branch
2 times, most recently
from
3dfddad to
d69a34c
Compare
QuLogic
reviewed
Jan 18, 2021
This brings the bounds logic from contourf into contour to properly update the extents of the plot.
The contour image had bounds of (-176, 176) rather than going out to the full extent. Now that we are properly calculating the bounds within contour, the image has changed.
greglucas
force-pushed
the
contour_bounds
branch
from
d69a34c to
2a5b90d
Compare
QuLogic
approved these changes
Jan 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1673
Rationale
The extent of the projection wasn't getting updated, which caused other failures downstream. This just copies the logic from
contourfintocontourto update the bounds.2nd commit updates the global contour wrap image. This previously had incorrect extents of (-176, 176), which this update illuminated and caused the extents to go out to the full range now (-180, 180). I didn't want to mess with MPL2 test images, so just manually fixed the extent for that case.
3rd commit is just extra flake8 updates that I didn't want to do in a separate PR. Can remove if desired.