Updating minimum versions of dependencies on Travis #1575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we remove the figures created with MPL 1.5 in tests, once this PR is accepted? |
|
Good suggestion, I went through and tried to remove all of the MPL version checks that were less than the minimum supported. Similar could be done with PROJ too I'm guessing. |
greglucas
changed the title
|
I'm 💯 on the concept. Supporting matplotlib 1.5 through 3.3 with image tests is just untenable. Personally, I'd say go ahead and remove the 1.5 test images in this PR as well. |
|
The old images should have all been removed before, just needed a rebase. Let me know if you saw others specifically in there that I should remove too. |
dopplershift
approved these changes
Jul 15, 2020
QuLogic
reviewed
Jul 15, 2020
|
Natural Earth download servers are down right now causing the failures. |
greglucas
force-pushed
the
update_travis
branch
from
93b02f7 to
a5e2162
Compare
greglucas
force-pushed
the
update_travis
branch
2 times, most recently
from
6487fe4 to
7fa9c8a
Compare
dopplershift
approved these changes
Aug 21, 2020
…sions to the test suite. TST: Changing the Travis minimum Python version to 3.6
greglucas
force-pushed
the
update_travis
branch
from
7fa9c8a to
67fbd8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few oddities that I couldn't figure out, like why the gridliners are so much different with these new versions, needing to greatly increase the tolerance. The images all look so-so with what appears to be only text position moving.
Rationale
The old versions of dependencies are getting difficult to maintain and test against. This adopts the 24-month NEP29 versions discussed in #1518.
Implications
Not supporting older versions of dependencies anymore.
Easier test suite to maintain.