This repository has been archived by the owner on Feb 17, 2023. It is now read-only.
Python 3 source compatibility #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This basically does nothing but provide consistency, though everything already works fine.
Again, this makes no difference as it was already enabled in places where necessary.
Again, no other changes necessary.
Most calls do not need changing; a few explicit izip's can now revert to normal zip.
| @@ -177,7 +180,7 @@ def zeros_adapter(self, shape, dtype='f', keys=()): | |||
| return self.wrap(ndarray, keys) | |||
|
|
|||
| def arange_adapter(self, shape, keys): | |||
| size = reduce(lambda x, y: x * y, shape) | |||
| size = np.product(shape) | |||
|
Yet another awesome PR. Thanks @QuLogic! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2to3 is the old method, and somewhat annoying. You need to run an extra translation step, which is (albeit minimally) slower, and you can't do an editable install because the source is not really Python 3 compatible.
This does add a dependency on six, but I think it's ubiquitous enough now to not be a problem.