Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update URL #3

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Update URL #3

wants to merge 5 commits into from

Conversation

wolvespaw
Copy link

Issue #2 : links have been updated. currently, the link redirects to the regex documentation for the current rust release

@wolvespaw
Copy link
Author

Feel free to ignore the "purge greps" commit.
That was supposed to stay on my fork until I at least make sure I didn't break anything.
And it's terribly inefficient since I am focusing more on making sure I know what the code does than on efficiency at the moment.

@wolvespaw wolvespaw closed this Aug 15, 2018
@ashfordneil
Copy link
Collaborator

I think the link should be a docs.rs link, so we can pin the version number to what we’re using.

@wolvespaw
Copy link
Author

I'll look into it.
Do you know what rust build was used?
(would be a bit faster than tracing through the code)
With how it's written, it looks like the regex version will be tied to which version of rust it was compiled with.

@ashfordneil
Copy link
Collaborator

regex hasn’t been part of rust itself for quite a while now, it’s just an external library. The version number used is in cargo.toml and cargo.lock, but the latest version number available is on https://crates.io.

@wolvespaw wolvespaw reopened this Aug 19, 2018
@wolvespaw
Copy link
Author

@ashfordneil the ink is now pointing to the regex library version currently in use.
still need to update the regex library since it's behind by a major version (in use 0.2.6, current: >1.0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants