Skip to content

Commit

Permalink
avoid modifying collection
Browse files Browse the repository at this point in the history
  • Loading branch information
barfeous committed Feb 12, 2024
1 parent 8cab730 commit eb0f025
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ private ConcreteFunction maybe_uncache_variable_captures(ConcreteFunction concre

public override (IList<Trackable>, IDictionary<Trackable, IEnumerable<TrackableReference>>) breadth_first_traversal()
{
Trackable get_merged_trackable(Trackable x)
void merged_trackable(Trackable x)
{
// TODO: complete it with new definitions `Asset` and `TrackableConstant`.
return x;

Check failure on line 94 in src/TensorFlowNET.Core/Training/Saving/SavedModel/AugmentedGraphView.cs

View workflow job for this annotation

GitHub Actions / linux

Since 'merged_trackable(Trackable)' returns void, a return keyword must not be followed by an object expression

Check failure on line 94 in src/TensorFlowNET.Core/Training/Saving/SavedModel/AugmentedGraphView.cs

View workflow job for this annotation

GitHub Actions / linux

Since 'merged_trackable(Trackable)' returns void, a return keyword must not be followed by an object expression

Check failure on line 94 in src/TensorFlowNET.Core/Training/Saving/SavedModel/AugmentedGraphView.cs

View workflow job for this annotation

GitHub Actions / linux

Since 'merged_trackable(Trackable)' returns void, a return keyword must not be followed by an object expression

Check failure on line 94 in src/TensorFlowNET.Core/Training/Saving/SavedModel/AugmentedGraphView.cs

View workflow job for this annotation

GitHub Actions / linux

Since 'merged_trackable(Trackable)' returns void, a return keyword must not be followed by an object expression

Check failure on line 94 in src/TensorFlowNET.Core/Training/Saving/SavedModel/AugmentedGraphView.cs

View workflow job for this annotation

GitHub Actions / windows

Since 'merged_trackable(Trackable)' returns void, a return keyword must not be followed by an object expression

Check failure on line 94 in src/TensorFlowNET.Core/Training/Saving/SavedModel/AugmentedGraphView.cs

View workflow job for this annotation

GitHub Actions / windows

Since 'merged_trackable(Trackable)' returns void, a return keyword must not be followed by an object expression

Check failure on line 94 in src/TensorFlowNET.Core/Training/Saving/SavedModel/AugmentedGraphView.cs

View workflow job for this annotation

GitHub Actions / windows

Since 'merged_trackable(Trackable)' returns void, a return keyword must not be followed by an object expression

Check failure on line 94 in src/TensorFlowNET.Core/Training/Saving/SavedModel/AugmentedGraphView.cs

View workflow job for this annotation

GitHub Actions / windows

Since 'merged_trackable(Trackable)' returns void, a return keyword must not be followed by an object expression
Expand All @@ -100,7 +100,7 @@ Trackable get_merged_trackable(Trackable x)
// skip the deletion of cache (maybe do it later).
foreach(var pair in _children_cache[obj])
{
_children_cache[obj][pair.Key] = get_merged_trackable(pair.Value);
merged_trackable(pair.Value);
}
}

Expand Down

0 comments on commit eb0f025

Please sign in to comment.