fix: fix remake for IntervalNonlinearProblem
#727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisRackauckas
approved these changes
Jun 28, 2024
test/remake_tests.jl
Outdated
| uspan = (1.0, 2.0) | ||
| prob_int = IntervalNonlinearProblem(interval_f, uspan) | ||
| prob2 = @inferred IntervalNonlinearProblem remake(prob_int; p = [0]) | ||
| @test prob2.p == [2] |
There was a problem hiding this comment.
@test prob2.p == [0]
sol = solve(prob2)
@test sol.prob.p == [0]
@test sol.u ≈ √2There was a problem hiding this comment.
This test code is a modified version of the tutorial in the documentation here. It does not use @inferred.
There was a problem hiding this comment.
Thanks for pointing out the test error. @inferred is here to ensure the remake call is inferred (as much as possible). This testset is concerned with remake, so testing the solve does not belong here; that's something that should happen in SimpleNonlinearSolve.
AayushSabharwal
force-pushed
the
as/interval-nonlinear-problem
branch
from
ea1e723 to
32ff4de
Compare
test/remake_tests.jl
Outdated
| uspan = (1.0, 2.0) | ||
| prob_int = IntervalNonlinearProblem(interval_f, uspan) | ||
| prob2 = @inferred IntervalNonlinearProblem remake(prob_int; p = [0]) | ||
| @test prob2.p == [0] |
There was a problem hiding this comment.
Then I would simplify the problem and naming.
interval_f(u, p) = u + p[1]
uspan = (-1.0, 1.0)
interval_prob = IntervalNonlinearProblem(interval_f, uspan)
new_prob = @inferred IntervalNonlinearProblem remake(interval_prob; p = [0])
@test new_prob.p == [0]
AayushSabharwal
force-pushed
the
as/interval-nonlinear-problem
branch
from
32ff4de to
bfbb09e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #726
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.