-
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use getu
/setu
for all indexing
#721
refactor: use getu
/setu
for all indexing
#721
Conversation
Eventually I'll move these to SII's downstream testset |
this looks great! one question is now that all these getindexes just call getu, could they all be merged into a single method? |
I'm happy to give it a shot, but defining these methods with a Also, |
The tests have been quite heavily modified, so I cannot really tell if they are the same or no. If you say they are the same I trust you. |
How is this going? |
The added tests pass locally last I checked, but the core CI is failing due to an error I haven't been able to reproduce yet (even with In fact, even in downstream CI all the depwarns are erroring. I guess tests are now running with |
0248403
to
10f71ab
Compare
@TorkelE I moved your symbolic indexing tests here, added some more, and replaced
symbol_indexing.jl
. I've ensured everything insymbol_indexing.jl
is still tested somewhere. Tests pass using MTK masterChecklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.