Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make nonlinear problem mutable #708

Merged
merged 4 commits into from
Jun 9, 2024
Merged

make nonlinear problem mutable #708

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ace0b32
make nonlinear problem mutable
m-bossart Jun 7, 2024
169f108
Add ImmutableNonlinearProblem
m-bossart Jun 8, 2024
f296fac
remove immutable nonlinear
m-bossart Jun 8, 2024
5146f38
remove static arrays using
m-bossart Jun 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/problems/basic_problems.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@
* `p`: The parameters for the problem. Defaults to `NullParameters`.
* `kwargs`: The keyword arguments passed on to the solvers.
"""
struct NonlinearProblem{uType, isinplace, P, F, K, PT} <:
mutable struct NonlinearProblem{uType, isinplace, P, F, K, PT} <:
AbstractNonlinearProblem{uType, isinplace}
f::F
u0::uType
Expand Down Expand Up @@ -312,6 +312,18 @@
NonlinearProblem{isinplace(prob)}(prob.f, prob.u0, prob.p; prob.kwargs...)
end

function Base.setproperty!(prob::NonlinearProblem, s::Symbol, v)
@warn "Mutation of NonlinearProblem detected. SciMLBase v2.0 has made NonlinearProblem temporarily mutable in order to allow for interfacing with EnzymeRules due to a current limitation in the rule system. This change is only intended to be temporary and NonlinearProblem will return to being a struct in a later non-breaking release. Do not rely on this behavior, use with caution."
Base.setfield!(prob, s, v)

Check warning on line 317 in src/problems/basic_problems.jl

View check run for this annotation

Codecov / codecov/patch

src/problems/basic_problems.jl#L315-L317 

Added lines #L315 - L317 were not covered by tests
end

function Base.setproperty!(prob::NonlinearProblem, s::Symbol, v, order::Symbol)
@warn "Mutation of NonlinearProblem detected. SciMLBase v2.0 has made NonlinearProblem temporarily mutable in order to allow for interfacing with EnzymeRules due to a current limitation in the rule system. This change is only intended to be temporary and NonlinearProblem will return to being a struct in a later non-breaking release. Do not rely on this behavior, use with caution."
Base.setfield!(prob, s, v, order)

Check warning on line 322 in src/problems/basic_problems.jl

View check run for this annotation

Codecov / codecov/patch

src/problems/basic_problems.jl#L320-L322 

Added lines #L320 - L322 were not covered by tests
end



@doc doc"""
Defines a nonlinear least squares problem.

Expand Down
Loading