Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error when interpolating derivatives of observed variables #688

Merged

Conversation

AayushSabharwal
Copy link
Member

Close SciML/ModelingToolkit.jl#2697

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

Copy link

codecov bot commented May 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 4.81%. Comparing base (a0fab7a) to head (5860b14).

Files Patch % Lines
src/solutions/ode_solutions.jl 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #688       +/-   ##
==========================================
- Coverage   31.79%   4.81%   -26.99%     
==========================================
  Files          55      55               
  Lines        4535    4506       -29     
==========================================
- Hits         1442     217     -1225     
- Misses       3093    4289     +1196     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisRackauckas ChrisRackauckas merged commit 3b387e8 into SciML:master May 8, 2024
45 of 82 checks passed
@AayushSabharwal AayushSabharwal deleted the as/observed-derivative-error branch May 8, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Silent and wrong derivatives of observed variables
2 participants