Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: batch observed function eval in plotting, bug fixes #680

Merged
merged 6 commits into from
May 2, 2024

Conversation

AayushSabharwal
Copy link
Member

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@AayushSabharwal
Copy link
Member Author

Copy link

codecov bot commented Apr 30, 2024

Codecov Report

Attention: Patch coverage is 94.44444% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 41.00%. Comparing base (9e92fc6) to head (668f3f7).
Report is 4 commits behind head on master.

Files Patch % Lines
src/solutions/ode_solutions.jl 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #680      +/-   ##
==========================================
+ Coverage   31.74%   41.00%   +9.25%     
==========================================
  Files          55       55              
  Lines        4505     4529      +24     
==========================================
+ Hits         1430     1857     +427     
+ Misses       3075     2672     -403     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AayushSabharwal
Copy link
Member Author

Requires SciML/SymbolicIndexingInterface.jl#72

@ChrisRackauckas ChrisRackauckas merged commit 4140290 into SciML:master May 2, 2024
34 of 42 checks passed
@AayushSabharwal AayushSabharwal deleted the myb/batch branch May 2, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants