Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw an error if p is supplied as kwarg #569

Merged
merged 1 commit into from
Dec 24, 2023
Merged

Conversation

avik-pal
Copy link
Member

Copy link

codecov bot commented Dec 24, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (483d022) 26.37% compared to head (91f651d) 5.26%.

Files Patch % Lines
src/problems/basic_problems.jl 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #569       +/-   ##
==========================================
- Coverage   26.37%   5.26%   -21.11%     
==========================================
  Files          53      53               
  Lines        4087    4061       -26     
==========================================
- Hits         1078     214      -864     
- Misses       3009    3847      +838     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisRackauckas ChrisRackauckas merged commit acdb34f into master Dec 24, 2023
32 of 42 checks passed
@ChrisRackauckas ChrisRackauckas deleted the ap/err_kwarg branch December 24, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remake defined but doesn't seem to do anything
2 participants