Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor SDEProblem constructor #489

Merged
merged 4 commits into from
Sep 22, 2023

Conversation

ErikQQY
Copy link
Member

@ErikQQY ErikQQY commented Sep 7, 2023

Follow #487

Now we can define an SDEProblem by:

  1. prob = SDEProblem(f, g, u0, tspan)
  2. prob = SDEProblem(SDEFunction(f, g), u0, tspan) (Before we construct SDEProblem usingSDEProblem(SDEFunction(f, g), g, u0, tspan))

This PR would break a lot of downstream packages, especially the SDE stuff

@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #489 (cf4c46f) into master (03cdaed) will decrease coverage by 5.50%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##           master     #489      +/-   ##
==========================================
- Coverage   57.27%   51.78%   -5.50%     
==========================================
  Files          50       50              
  Lines        3703     3694       -9     
==========================================
- Hits         2121     1913     -208     
- Misses       1582     1781     +199     
Files Changed Coverage Δ
src/problems/sde_problems.jl 33.33% <25.00%> (-22.55%) ⬇️

... and 12 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ChrisRackauckas ChrisRackauckas merged commit 5f41700 into SciML:master Sep 22, 2023
1 of 4 checks passed
@ChrisRackauckas
Copy link
Member

I'm merging this to get it included in the v2 breaking changes. @ErikQQY can you prioritize fixing the downstream usage here a bit? I think we need to just get it done now so that way it's with the breaking change and thus everything updates appropriately.

@ErikQQY
Copy link
Member Author

ErikQQY commented Sep 22, 2023

Sure, I am working on the downstream errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants