Add left & right params for Bracketing methods #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #16 +/- ##
======================================
Coverage 2.87% 2.87%
======================================
Files 37 37
Lines 2712 2712
======================================
Hits 78 78
Misses 2634 2634
Continue to review full report at Codecov.
|
|
I don't think it makes sense to double up. We might as well have a canonical left or right choice, since it will be required that |
|
Yes, I was thinking of that. I guess |
utkarsh530
commented
Feb 1, 2021
| end | ||
|
|
||
| function sensitivity_solution(sol::AbstractNonlinearProblem,u) | ||
| function sensitivity_solution(sol::AbstractNonlinearSolution,u) |
There was a problem hiding this comment.
Probably there was a typo here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have kept all
u,left&rightfor compatibility issues. I will setutoleftin case of bracketing methods. Should I also setleft = uimplicitly?Ref: SciML/NonlinearSolve.jl#28
@ChrisRackauckas @YingboMa , please review.