Fix bcresid_prototype in TwoPointBVPFunction

Signed-off-by: ErikQQY <[email protected]>
SciML · Oct 8, 2023 · bf167ce · bf167ce
1 parent c6623b2
commit bf167ce
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/src/scimlfunctions.jl b/src/scimlfunctions.jl
@@ -4067,8 +4067,8 @@ function BVPFunction{iip, specialize, twopoint}(f, bc;
     end
 
     if twopoint
-        if iip && (bcresid_prototype === nothing || length(bcresid_prototype) != 2)
-            error("bcresid_prototype must be a tuple / indexable collection of length 2 for a inplace TwoPointBVPFunction")
+        if iip && bcresid_prototype !== nothing
+            @assert length(bcresid_prototype) == 2 error("bcresid_prototype must be a tuple / indexable collection of length 2 for an inplace TwoPointBVPFunction")
         end
         if bcresid_prototype !== nothing && length(bcresid_prototype) == 2
             bcresid_prototype = ArrayPartition(first(bcresid_prototype),

diff --git a/test/function_building_error_messages.jl b/test/function_building_error_messages.jl
@@ -618,6 +618,14 @@ BVPFunction(bfiip, bciip, vjp = bvjp)
 
 @test_throws SciMLBase.NonconformingFunctionsError BVPFunction(bfoop, bciip, vjp = bvjp)
 
+# TwoPointBVPFunction
+
+tpbvpf(du, u, p, t) = du .= u
+tpbvpbca(resa, ua, p) = resa .= ua
+tpbvpbcb(resb, ub, p) = resb .= ub
+SciMLBase.TwoPointBVPFunction(tpbvpf, (tpbvpbca, tpbvpbcb))
+@test_throws ErrorException SciMLBase.TwoPointBVPFunction(tpbvpf, (tpbvpbca, tpbvpbcb), bcresid_prototype = (1, 1, 1))
+
 # IntegralFunction
 
 ioop(u, p) = p * u