Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add test for is_event_assignment #171

Merged
merged 5 commits into from
Dec 12, 2024
Merged

add test for is_event_assignment #171

merged 5 commits into from
Dec 12, 2024

Conversation

paulflang
Copy link
Member

@paulflang paulflang commented Dec 2, 2024 •
edited
Loading

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

There was a bug when parameters or compartments are not constant and modified in an event. This PR is a fix.

@paulflang paulflang mentioned this pull request Dec 2, 2024
Open
@paulflang paulflang marked this pull request as ready for review December 2, 2024 16:58
@paulflang paulflang merged commit 8ca157c into main Dec 12, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@paulflang