-
-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add keyword alias_u0
with default value false
#655
Conversation
src/integrators/type.jl
Outdated
@@ -43,6 +43,7 @@ mutable struct DEOptions{absType,relType,QT,tType,F1,F2,F3,F4,F5,F6,tstopsType,d | |||
force_dtmin::Bool | |||
advance_to_tstop::Bool | |||
stop_at_next_tstop::Bool | |||
alias_u0::Bool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure this is actually necessary since it's not used for anything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll remove it.
This looks good, but we need to change the other solver packages as well to keep uniformity in the common interface. |
Is this list of packages that have to be updated complete?
|
I think DelayDiffEq might be fine. GeometricIntegratorsDiffEq.jl and BridgeDiffEq.jl should get an update though tests are failing, and LSODA.jl should update. |
Okay. I've missed LSODA.jl because it's not part of JuliaDiffEq. |
I can't really see a possibility for aliasing for https://github.com/JuliaDiffEq/BridgeDiffEq.jl. |
Yes that just uses small immutables. |
Maybe it would be more intuitive to never alias the |
True that would make sense. |
Cf. #654 (comment) and #640.
This is my first PR changing some keyword arguments. Hence, it should be reviewed carefully because I might have missed some connections to other parts.