Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add keyword alias_u0 with default value false #655

Merged
merged 2 commits into from
Feb 9, 2019

Conversation

ranocha
Copy link
Member

@ranocha ranocha commented Feb 8, 2019

Cf. #654 (comment) and #640.

This is my first PR changing some keyword arguments. Hence, it should be reviewed carefully because I might have missed some connections to other parts.

@@ -43,6 +43,7 @@ mutable struct DEOptions{absType,relType,QT,tType,F1,F2,F3,F4,F5,F6,tstopsType,d
force_dtmin::Bool
advance_to_tstop::Bool
stop_at_next_tstop::Bool
alias_u0::Bool
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this is actually necessary since it's not used for anything.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll remove it.

@ChrisRackauckas
Copy link
Member

This looks good, but we need to change the other solver packages as well to keep uniformity in the common interface.

@ChrisRackauckas
Copy link
Member

I think DelayDiffEq might be fine. GeometricIntegratorsDiffEq.jl and BridgeDiffEq.jl should get an update though tests are failing, and LSODA.jl should update.

@ranocha
Copy link
Member Author

ranocha commented Feb 9, 2019

Okay. I've missed LSODA.jl because it's not part of JuliaDiffEq.

@ranocha
Copy link
Member Author

ranocha commented Feb 9, 2019

I can't really see a possibility for aliasing for https://github.com/JuliaDiffEq/BridgeDiffEq.jl.

@ChrisRackauckas
Copy link
Member

Yes that just uses small immutables.

@devmotion
Copy link
Member

I think DelayDiffEq might be fine.

Maybe it would be more intuitive to never alias the ODEIntegrator that is created in DelayDiffEq but depending on the keyword alias_u0 change the DDEIntegrator in https://github.com/JuliaDiffEq/DelayDiffEq.jl/blob/master/src/solve.jl#L114-L117?

@ChrisRackauckas
Copy link
Member

True that would make sense.

@ChrisRackauckas ChrisRackauckas merged commit 232bbea into SciML:master Feb 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants