This repository has been archived by the owner on Sep 9, 2024. It is now read-only.
example of a user defined type #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There doesn't seem to be an example showing what's required for the user to define their own type. |
Current coverage is 93.65%
|
| end | ||
|
|
||
| # Necessary for the solver | ||
| Base.(:/)(x::Vec2, y::Real) = Vec2(x.a/y, x.b/y) |
There was a problem hiding this comment.
To make this 0.5-proof: @compat Base.:+
|
Thanks, this is good! Maybe a few sentences comments would be good: what the example is about, maybe a word about the ODE. There is also the test-case |
|
Looks good to me. Someone please merge this, unless there are objections. |
|
Looks good to me as well. Merging. |
|
Ah, yes, we can merge now! ;-) Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.