refactor: use DI.jl for the jacobian stuff #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
avik-pal
commented
Sep 26, 2024
•
avik-pal
commented
- cleaned up the scalar stuff. fixes Analytical Jacobian is not being used in the 3.13 version of NonlinearSolve #451
- partially addresses Start using DifferentiationInterface.jl #415. For now we use the dense AD from DI
avik-pal
force-pushed
the
ap/clean_jac
branch
3 times, most recently
from
aa6334b to
9a4d05f
Compare
fix: stop storing extra stuff in JacobianCache feat: use DI for dense jacobians refactor: remove alg from the cache fix: don't ignore sparsity for dense_ad
avik-pal
force-pushed
the
ap/clean_jac
branch
from
9a4d05f to
6277187
Compare
avik-pal
force-pushed
the
ap/clean_jac
branch
from
19182ae to
ef2ab48
Compare
avik-pal
force-pushed
the
ap/clean_jac
branch
from
ef2ab48 to
59347e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.