-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use LinearSolve precs setup #462
Conversation
This would require a major version bump. |
See also this Julia Discourse post. |
Is this needed? |
it's not needed, but will be nice (as it will bring the interface inline with LinearSolve and OrdinaryDiffEq@V7 |
okay, I thought it was covered by another PR already. |
#465 was a simpler fix that fixed the bug that led me to create this PR, but all that did was switch NonlinearSolve from a cursed diagonal preconditioner to a real diagonal preconditioner, whereas this PR removes the preconditioner from the NonlinearSolve side entirely since the LinearSolve side can do all the work. |
@avik-pal if I rebase this, do you think we're ready to do the version bump required? I think this is a good change, but I don't really want to go through the rebase until you think we're conceptually ready to merge. |
not yet, we need #458 to be merged before doing a bump |
@oscardssmith we can get this in now |
This updates NonlinearSolve to use the new
precs
interface in LinearSolve.