Remove recompile_invalidations #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`@recompile_invalidations` should only be used in very specific scenarios, and this is not one of those scenarios. Also, there are big changes being done with https://github.com/SciML/CommonWorldInvalidations.jl. With that, we only need to `@recompile_invalidations` on a few entry points. In particular, Static.jl, Symbolics.jl, and preferably ForwardDiff.jl and StaticArrays.jl would adopt it too. But this means that in order to handle all of this effectively, in SciML we only need to apply it on Static.jl, Symbolics.jl, and SciMLBase.jl and the whole ecosystem should be fine. In any case, this library doesn't need it. It shouldn't make a tangible difference in compile times, while it increases precompile times by a lot.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
oscardssmith
approved these changes
Jun 27, 2024
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
src/NonlinearSolve.jl
Outdated
Comment on lines
13
to
14
| using ADTypes: AutoSparseFiniteDiff, AutoSparseForwardDiff, | ||
| AutoSparsePolyesterForwardDiff, AutoSparseZygote |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| using ADTypes: AutoSparseFiniteDiff, AutoSparseForwardDiff, | |
| AutoSparsePolyesterForwardDiff, AutoSparseZygote | |
| using ADTypes: AutoSparseFiniteDiff, AutoSparseForwardDiff, AutoSparsePolyesterForwardDiff, | |
| AutoSparseZygote |
src/NonlinearSolve.jl
Outdated
Comment on lines
31
to
32
| UpperTriangular, axpy!, cond, diag, diagind, dot, issuccess, | ||
| istril, istriu, lu, mul!, norm, pinv, tril!, triu! |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| UpperTriangular, axpy!, cond, diag, diagind, dot, issuccess, | |
| istril, istriu, lu, mul!, norm, pinv, tril!, triu! | |
| UpperTriangular, axpy!, cond, diag, diagind, dot, issuccess, istril, | |
| istriu, lu, mul!, norm, pinv, tril!, triu! |
src/NonlinearSolve.jl
Outdated
Comment on lines
47
to
50
| SymbolicsSparsityDetection, auto_jacvec, auto_jacvec!, | ||
| auto_vecjac, init_jacobian, num_jacvec, num_jacvec!, num_vecjac, | ||
| num_vecjac!, sparse_jacobian, sparse_jacobian!, | ||
| sparse_jacobian_cache |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| SymbolicsSparsityDetection, auto_jacvec, auto_jacvec!, | |
| auto_vecjac, init_jacobian, num_jacvec, num_jacvec!, num_vecjac, | |
| num_vecjac!, sparse_jacobian, sparse_jacobian!, | |
| sparse_jacobian_cache | |
| SymbolicsSparsityDetection, auto_jacvec, auto_jacvec!, auto_vecjac, | |
| init_jacobian, num_jacvec, num_jacvec!, num_vecjac, num_vecjac!, | |
| sparse_jacobian, sparse_jacobian!, sparse_jacobian_cache |
src/NonlinearSolve.jl
Outdated
Comment on lines
53
to
54
| symbolic_container, parameter_values, state_values, | ||
| getu, setu |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| symbolic_container, parameter_values, state_values, | |
| getu, setu | |
| symbolic_container, parameter_values, state_values, getu, | |
| setu |
src/NonlinearSolve.jl
Outdated
Comment on lines
31
to
32
| UpperTriangular, axpy!, cond, diag, diagind, dot, issuccess, | ||
| istril, istriu, lu, mul!, norm, pinv, tril!, triu! |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| UpperTriangular, axpy!, cond, diag, diagind, dot, issuccess, | |
| istril, istriu, lu, mul!, norm, pinv, tril!, triu! | |
| UpperTriangular, axpy!, cond, diag, diagind, dot, issuccess, istril, | |
| istriu, lu, mul!, norm, pinv, tril!, triu! |
src/NonlinearSolve.jl
Outdated
Comment on lines
47
to
50
| SymbolicsSparsityDetection, auto_jacvec, auto_jacvec!, | ||
| auto_vecjac, init_jacobian, num_jacvec, num_jacvec!, num_vecjac, | ||
| num_vecjac!, sparse_jacobian, sparse_jacobian!, | ||
| sparse_jacobian_cache |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| SymbolicsSparsityDetection, auto_jacvec, auto_jacvec!, | |
| auto_vecjac, init_jacobian, num_jacvec, num_jacvec!, num_vecjac, | |
| num_vecjac!, sparse_jacobian, sparse_jacobian!, | |
| sparse_jacobian_cache | |
| SymbolicsSparsityDetection, auto_jacvec, auto_jacvec!, auto_vecjac, | |
| init_jacobian, num_jacvec, num_jacvec!, num_vecjac, num_vecjac!, | |
| sparse_jacobian, sparse_jacobian!, sparse_jacobian_cache |
src/NonlinearSolve.jl
Outdated
Comment on lines
53
to
54
| symbolic_container, parameter_values, state_values, | ||
| getu, setu |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| symbolic_container, parameter_values, state_values, | |
| getu, setu | |
| symbolic_container, parameter_values, state_values, getu, | |
| setu |
src/NonlinearSolve.jl
Outdated
Comment on lines
31
to
32
| UpperTriangular, axpy!, cond, diag, diagind, dot, issuccess, | ||
| istril, istriu, lu, mul!, norm, pinv, tril!, triu! |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| UpperTriangular, axpy!, cond, diag, diagind, dot, issuccess, | |
| istril, istriu, lu, mul!, norm, pinv, tril!, triu! | |
| UpperTriangular, axpy!, cond, diag, diagind, dot, issuccess, istril, | |
| istriu, lu, mul!, norm, pinv, tril!, triu! |
src/NonlinearSolve.jl
Outdated
Comment on lines
52
to
53
| symbolic_container, parameter_values, state_values, | ||
| getu, setu |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| symbolic_container, parameter_values, state_values, | |
| getu, setu | |
| symbolic_container, parameter_values, state_values, getu, | |
| setu |
src/NonlinearSolve.jl
Outdated
Comment on lines
52
to
53
| symbolic_container, parameter_values, state_values, | ||
| getu, setu |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| symbolic_container, parameter_values, state_values, | |
| getu, setu | |
| symbolic_container, parameter_values, state_values, getu, | |
| setu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@recompile_invalidationsshould only be used in very specific scenarios, and this is not one of those scenarios. Also, there are big changes being done with https://github.com/SciML/CommonWorldInvalidations.jl. With that, we only need to@recompile_invalidationson a few entry points. In particular, Static.jl, Symbolics.jl, and preferably ForwardDiff.jl and StaticArrays.jl would adopt it too. But this means that in order to handle all of this effectively, in SciML we only need to apply it on Static.jl, Symbolics.jl, and SciMLBase.jl and the whole ecosystem should be fine.In any case, this library doesn't need it. It shouldn't make a tangible difference in compile times, while it increases precompile times by a lot.