Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to ADTypes v1 #426

Merged
merged 10 commits into from
May 16, 2024
Merged

Upgrade to ADTypes v1 #426

merged 10 commits into from
May 16, 2024

Conversation

gdalle
Copy link
Collaborator

@gdalle gdalle commented May 15, 2024

Supersedes #412

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@gdalle gdalle changed the title Updates to ADTypes v1 Upgrade to ADTypes v1 May 15, 2024
Copy link

codecov bot commented May 15, 2024

Codecov Report

Attention: Patch coverage is 96.87500% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 85.70%. Comparing base (17bb8a8) to head (844d78c).

Files Patch % Lines
src/internal/jacobian.jl 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #426      +/-   ##
==========================================
- Coverage   86.30%   85.70%   -0.60%     
==========================================
  Files          47       47              
  Lines        2913     2904       -9     
==========================================
- Hits         2514     2489      -25     
- Misses        399      415      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/internal/helpers.jl Outdated Show resolved Hide resolved
@gdalle
Copy link
Collaborator Author

gdalle commented May 16, 2024

I don't understand what the formatting check does? It doesn't seem related to JuliaFormatter

@ChrisRackauckas
Copy link
Member

It is JuliaFormatter. It's saying you haven't ran the formatter on this.

@gdalle gdalle marked this pull request as ready for review May 16, 2024 12:39
@gdalle gdalle requested a review from avik-pal May 16, 2024 12:40
@gdalle
Copy link
Collaborator Author

gdalle commented May 16, 2024

@avik-pal this is starting to look decent in my view

Copy link
Member

@avik-pal avik-pal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failures are either codecov update failure or same as master

@ChrisRackauckas ChrisRackauckas merged commit e7c64c3 into SciML:master May 16, 2024
12 of 18 checks passed
@gdalle gdalle deleted the gd/adtypes_v1 branch May 17, 2024 05:03
@gdalle
Copy link
Collaborator Author

gdalle commented May 17, 2024

Thanks for the merge! Can we tag a new release?

#429

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants