-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to ADTypes v1 #426
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #426 +/- ##
==========================================
- Coverage 86.30% 85.70% -0.60%
==========================================
Files 47 47
Lines 2913 2904 -9
==========================================
- Hits 2514 2489 -25
- Misses 399 415 +16 ☔ View full report in Codecov by Sentry. |
I don't understand what the formatting check does? It doesn't seem related to JuliaFormatter |
It is JuliaFormatter. It's saying you haven't ran the formatter on this. |
@avik-pal this is starting to look decent in my view |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test failures are either codecov update failure or same as master
Thanks for the merge! Can we tag a new release? |
Supersedes #412
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.