Simplify precompilation #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove Float32 method and the Vector out of place methods since these are less likely to be useful to users. This brings down precompilation time by ~2x. I think this is good to do before SciML#418 since I'm more sure that it's a good idea.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #421 +/- ##
==========================================
- Coverage 86.34% 85.58% -0.77%
==========================================
Files 47 47
Lines 2914 2906 -8
==========================================
- Hits 2516 2487 -29
- Misses 398 419 +21 ☔ View full report in Codecov by Sentry. |
avik-pal
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove Float32 method and the Vector out of place methods since these are less likely to be useful to users. This brings down precompilation time by ~2x. I think this is good to do before #418 since I'm more sure that it's a good idea.