Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make __findmin type stable #393

Merged
merged 1 commit into from
Mar 23, 2024
Merged

Make __findmin type stable #393

merged 1 commit into from
Mar 23, 2024

Conversation

avik-pal
Copy link
Member

Last piece of removing all forms of dynamic dispatches from MIRK methods

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 78.57143% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 86.70%. Comparing base (3925219) to head (e6ff3aa).

Files Patch % Lines
src/utils.jl 78.57% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #393      +/-   ##
==========================================
- Coverage   86.73%   86.70%   -0.04%     
==========================================
  Files          46       46              
  Lines        2797     2805       +8     
==========================================
+ Hits         2426     2432       +6     
- Misses        371      373       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avik-pal avik-pal merged commit 28edcd4 into master Mar 23, 2024
12 of 17 checks passed
@avik-pal avik-pal deleted the ap/tstable_findmin branch March 23, 2024 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants