Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc. Improvements #390

Merged
merged 5 commits into from
Mar 6, 2024
Merged

Misc. Improvements #390

merged 5 commits into from
Mar 6, 2024

Conversation

avik-pal
Copy link
Member

@avik-pal avik-pal commented Mar 5, 2024

Checklist

  • Export wrappers over LineSearches (So that switching to LineSearch.jl becomes easier)
  • Ambiguity fixed
  • Polyalg in 23 test problems
  • Special case for small problems starting with a different polyalg
  • Incorrect Jacobian size for NLLS problems

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 96.77419% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 86.92%. Comparing base (52b3832) to head (81edf48).

Files Patch % Lines
src/default.jl 94.11% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #390       +/-   ##
===========================================
+ Coverage   56.66%   86.92%   +30.25%     
===========================================
  Files          46       46               
  Lines        2739     2760       +21     
===========================================
+ Hits         1552     2399      +847     
+ Misses       1187      361      -826     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avik-pal avik-pal changed the title [WIP] Misc. Improvements Misc. Improvements Mar 5, 2024
@avik-pal avik-pal merged commit e1c0528 into master Mar 6, 2024
14 of 17 checks passed
@avik-pal avik-pal deleted the ap/fixes branch March 6, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants