Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable formatting with join_lines_based_on_source=false #380

Merged
merged 1 commit into from
Feb 18, 2024

Conversation

avik-pal
Copy link
Member

Now that the bad formatting with this option has been fixed, disabling this makes the code look prettier.

Copy link

codecov bot commented Feb 18, 2024

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (c50c21a) 88.30% compared to head (c7e10db) 88.30%.

Files Patch % Lines
src/algorithms/extension_algs.jl 62.50% 3 Missing ⚠️
src/core/approximate_jacobian.jl 82.35% 3 Missing ⚠️
src/default.jl 84.21% 3 Missing ⚠️
ext/NonlinearSolveSIAMFANLEquationsExt.jl 81.81% 2 Missing ⚠️
src/descent/steepest.jl 33.33% 2 Missing ⚠️
src/internal/forward_diff.jl 50.00% 2 Missing ⚠️
src/core/generic.jl 80.00% 1 Missing ⚠️
src/internal/helpers.jl 90.00% 1 Missing ⚠️
src/internal/tracing.jl 90.90% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #380   +/-   ##
=======================================
  Coverage   88.30%   88.30%           
=======================================
  Files          44       44           
  Lines        2625     2626    +1     
=======================================
+ Hits         2318     2319    +1     
  Misses        307      307           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisRackauckas ChrisRackauckas merged commit d383660 into master Feb 18, 2024
12 of 16 checks passed
@ChrisRackauckas ChrisRackauckas deleted the ap/formatting branch February 18, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants