Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix autodiff=AutoFiniteDiff() for TrustRegion #361

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

oscardssmith
Copy link
Contributor

@oscardssmith oscardssmith commented Jan 31, 2024

Checklist

fixes #360

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7e0685a) 86.19% compared to head (cc3ebb7) 76.09%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #361       +/-   ##
===========================================
- Coverage   86.19%   76.09%   -10.11%     
===========================================
  Files          44       44               
  Lines        2608     2610        +2     
===========================================
- Hits         2248     1986      -262     
- Misses        360      624      +264     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avik-pal avik-pal merged commit 534c41c into SciML:master Feb 1, 2024
22 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TrustRegion(radius_update_scheme=RadiusUpdateSchemes.Bastin) doesn't respect autodiff setting .
2 participants