Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DAE Test Failures in OrdinaryDiffEq #355

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Fix DAE Test Failures in OrdinaryDiffEq #355

merged 2 commits into from
Jan 31, 2024

Conversation

avik-pal
Copy link
Member

@avik-pal avik-pal commented Jan 18, 2024

Strangely I can't locate the failing tests locally.

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7e0685a) 86.19% compared to head (9e0e0c4) 86.19%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #355      +/-   ##
==========================================
- Coverage   86.19%   86.19%   -0.01%     
==========================================
  Files          44       44              
  Lines        2608     2607       -1     
==========================================
- Hits         2248     2247       -1     
  Misses        360      360              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avik-pal avik-pal changed the title Re-trigger DAE Tests Fix DAE Test Failures in OrdinaryDiffEq Jan 31, 2024
@avik-pal
Copy link
Member Author

Finally OrdinaryDiffEq tests pass 🎉

@ChrisRackauckas ChrisRackauckas merged commit aecd854 into master Jan 31, 2024
27 of 28 checks passed
@ChrisRackauckas ChrisRackauckas deleted the ap/fix_dae branch January 31, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants