Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SIAMFANLEquations wrapper #333

Merged
merged 19 commits into from
Dec 24, 2023
Merged

Add SIAMFANLEquations wrapper #333

merged 19 commits into from
Dec 24, 2023

Conversation

ErikQQY
Copy link
Member

@ErikQQY ErikQQY commented Dec 19, 2023 •
edited
Loading

Fix #109

Checklist

  • Newton and PT solvers
  • JFNK linear solvers
  • Documentations
  • Test cases
  • Optimize NLstats, jacobian, and others

@codecov Codecov
Copy link

codecov bot commented Dec 19, 2023 •
edited
Loading

Codecov Report

Attention: 34 lines in your changes are missing coverage. Please review.

Comparison is base (eabb403) 88.47% compared to head (e2de813) 87.32%.

Files Patch % Lines
ext/NonlinearSolveSIAMFANLEquationsExt.jl 57.69% 33 Missing ⚠️
src/extension_algs.jl 75.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #333      +/-   ##
==========================================
- Coverage   88.47%   87.32%   -1.16%     
==========================================
  Files          26       27       +1     
  Lines        2048     2130      +82     
==========================================
+ Hits         1812     1860      +48     
- Misses        236      270      +34

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

avik-pal
avik-pal reviewed Dec 19, 2023
View reviewed changes
ext/NonlinearSolveSIAMFANLEquationsExt.jl Outdated Show resolved Hide resolved
src/extension_algs.jl Outdated Show resolved Hide resolved
src/extension_algs.jl Outdated Show resolved Hide resolved
@ErikQQY ErikQQY changed the title [WIP] Add SIAMFANLEquations wrapper Add SIAMFANLEquations wrapper Dec 23, 2023
@ChrisRackauckas
Copy link
Member

Just two comments to address.

ErikQQY and others added 4 commits December 24, 2023 12:02
@ErikQQY
typo
ce7a3c7 
Signed-off-by: ErikQQY <[email protected]>
@ErikQQY
delete print
80d2a19 
Signed-off-by: ErikQQY <[email protected]>
@ErikQQY
Update pages.jl
c0ece9d
@ErikQQY
Cover more tests
e2de813 
Signed-off-by: ErikQQY <[email protected]>
@ErikQQY ErikQQY requested a review from avik-pal December 24, 2023 16:38
ChrisRackauckas
ChrisRackauckas approved these changes Dec 24, 2023
View reviewed changes
Copy link
Member

@ChrisRackauckas ChrisRackauckas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good. Avik can follow up if he sees anything else.

@ChrisRackauckas ChrisRackauckas merged commit fa16796 into SciML:master Dec 24, 2023
17 of 21 checks passed
@ErikQQY ErikQQY deleted the qqy/siam_ext branch December 24, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisRackauckas ChrisRackauckas ChrisRackauckas approved these changes

@avik-pal avik-pal Awaiting requested review from avik-pal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrap SIAMFANLEquations
3 participants
@ErikQQY @ChrisRackauckas @avik-pal