Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trust Region Methods for Nonlinear Least Squares Problem #311

Merged
merged 1 commit into from
Dec 9, 2023

Conversation

avik-pal
Copy link
Member

@avik-pal avik-pal commented Dec 8, 2023

Lol, it was a 1 line change.

The Yuan scheme had an inconsistency, but it has been fixed.

Fixes #252

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (b0c28f1) 89.37% compared to head (26082c7) 89.20%.

Files Patch % Lines
src/jacobian.jl 85.71% 2 Missing ⚠️
src/trustRegion.jl 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #311      +/-   ##
==========================================
- Coverage   89.37%   89.20%   -0.18%     
==========================================
  Files          23       23              
  Lines        1939     1945       +6     
==========================================
+ Hits         1733     1735       +2     
- Misses        206      210       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avik-pal avik-pal force-pushed the ap/tr_nlls branch 2 times, most recently from cb21f74 to ee5356f Compare December 8, 2023 22:30
@avik-pal avik-pal merged commit 2a1d570 into SciML:master Dec 9, 2023
18 of 20 checks passed
@avik-pal avik-pal deleted the ap/tr_nlls branch December 9, 2023 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support line searches, trust region, and pseudo-transient with nonlinear least squares
2 participants